docs: update incremental benchmarks (3.6.0)#714
Conversation
Greptile SummaryThis automated PR updates the incremental benchmark document for the 3.6.0 release, adding WASM-only results (514 files, 6.1 s full build, 545 ms 1-file rebuild, 3.0× import speedup ratio) and a blockquote note explaining that the native engine is absent due to a Key changes:
Confidence Score: 5/5Safe to merge — documentation-only change with no code modifications; all data is internally consistent and the previous review concern is resolved. No P0 or P1 findings. Data in the markdown tables matches the embedded JSON (rounded values, percentage deltas computed against correct baseline versions), the native-absent note was explicitly requested and is now present, and the 3.5.0 notes block removal is appropriate since 3.6.0 is now the latest entry. No regressions or inconsistencies were found. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Workflow run #538\nbenchmark script] -->|3.6.0 data| B{Engine result}
B -->|WASM engine OK| C[WASM build metrics\nfull: 6.1s / noop: 13ms / 1-file: 545ms]
B -->|Native engine CRASH\nSQLITE_CORRUPT in\ndetect-changes /\npurgeAndAddReverseDeps| D[native: null]
C --> E[Import resolution\nboth engines ran OK\n904 pairs, native 4ms, JS 12ms]
D --> E
E --> F[Embedded JSON\nINCREMENTAL_BENCHMARK_DATA]
F --> G[Summary table row\n3.6.0 wasm only]
F --> H[Latest results section\n+blockquote note re: native crash]
G --> I[INCREMENTAL-BENCHMARKS.md]
H --> I
Reviews (3): Last reviewed commit: "Merge branch 'main' into benchmark/incre..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| | Version | Engine | Files | Full Build | No-op | 1-File | Resolve (native) | Resolve (JS) | | ||
| |---------|--------|------:|-----------:|------:|-------:|------------------:|-------------:| | ||
| | 3.6.0 | wasm | 514 | 6.1s | 13ms | 545ms | 4ms ↓3% | 12ms ↑9% | |
There was a problem hiding this comment.
3.6.0 has "native": null in the embedded JSON data, so only a wasm row appears in the summary table. For 3.5.0, the workflow generated a <!-- NOTES_START --> ... <!-- NOTES_END --> block explaining why both engines were null (napi-rs serialization bug, WAL race condition). That note has now been removed since 3.6.0 is the latest.
However, native was working in 3.4.1, and readers of this file have no indication of why the native engine is absent for 3.6.0. It may be worth adding a brief note in the "Latest results" section (or a comment in the JSON entry) explaining whether the native engine was intentionally skipped, failed during the benchmark run, or is being phased out.
There was a problem hiding this comment.
Addressed. Added a blockquote note in the "Latest results" section explaining that the native engine crashed with SQLITE_CORRUPT during the incremental rebuild tier (WAL corruption in detect-changes / purgeAndAddReverseDeps). See 839aa86.
Native worker crashed with SQLITE_CORRUPT during incremental rebuild (WAL corruption in detect-changes). Add a note so readers understand why only the WASM row appears.
|
@greptileai review |
|
@greptileai review |
1 participant
Automated incremental benchmark update for 3.6.0 from workflow run #538.